Avoid login issue in deployment E2E tests #2065
Conversation
WP admin email verification for an old WP 6.5 build appears to be causing a login failure error during the deployment tests. We aren't testing login, so lets just disable login for these tests.
brandonpayton
added
[Type] Bug
This is necessary to continue using the same logged-in screenshots for reference in the tests.
|
I'm not yet sure why CI continues to fail with these E2E tests. These changes seem to fix the testing issue when run locally with |
|
Hm, nothing obvious stands out to me 🤔 |
Thanks for considering this, @adamziel. Something strange is going on with the old version, but I don't think we need to understand why. Instead, I plan to just disable logins and update the old-version reference screenshots to match that. How did you originally generate the screenshots to match what CI will create? My plan is to just use a temp commit to generate the screenshots as part of the tests and then save those, but maybe there is a faster or easier way. Since I ran out of time this evening, I created #2071 to temporarily disable the tests before we can fix them properly. |
|
@brandonpayton I think I downloaded the CI artifacts and replaced the local screenshots – the CI runner had a different set of fonts than my mac so I couldn't easily use the ones generated locally. |
Motivation for the change, related issues
The deployment E2E tests are currently broken. WP admin email verification for an old WP 6.5 build appears to be causing a login failure error during the deployment tests.
An example of a failing screenshot comparison due to failed login is here.
Implementation details
This PR maxes out the
admin_email_lifespanvalue (for 32-bit PHP) so there should be no further admin email verification redirect.Testing Instructions (or ideally a Blueprint)